refactor: launcher imports shared profile.Config package#49
Closed
robbycochran wants to merge 1 commit into
Closed
refactor: launcher imports shared profile.Config package#49robbycochran wants to merge 1 commit into
robbycochran wants to merge 1 commit into
Conversation
…e package Replace duplicated Config struct, KeepSandbox(), and parseConfig() in sandbox/launcher with imports from internal/profile. The launcher module now depends on the parent module via a replace directive (resolved by go.work at build time). Launcher-specific functions (configureGateway, checkProviders, stageFiles, createSandbox, uploadFiles) are kept as-is. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closing: pivoting to single-binary approach. The launcher will be replaced by the harness binary in a container image, eliminating the need for go.work and the separate launcher module. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Configstruct,KeepSandbox(), andparseConfig()insandbox/launcher/main.gowith imports frominternal/profilesandbox/launcher/go.modwithreplacedirective (resolved locally bygo.work)sandbox/launcher/main_test.goto useprofile.ParseFileinstead of the removed localparseConfigLauncher-specific functions (
configureGateway,checkProviders,stageFiles,createSandbox,uploadFiles) are kept as-is -- they useexec.Commanddirectly and will be refactored separately.Stacked on #46 (
rc/phase2-agent-parser).Test plan
cd sandbox/launcher && CGO_ENABLED=0 go test ./...passescd sandbox/launcher && go vet ./...passesCGO_ENABLED=0 go test ./...(root) passes🤖 Generated with Claude Code